This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add post processing logic for aggregation query. #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dai-chen
reviewed
Jan 17, 2020
src/main/java/com/amazon/opendistroforelasticsearch/sql/expression/domain/BindingTuple.java
Outdated
Show resolved
Hide resolved
src/main/java/com/amazon/opendistroforelasticsearch/sql/expression/domain/BindingTuple.java
Outdated
Show resolved
Hide resolved
src/main/java/com/amazon/opendistroforelasticsearch/sql/expression/model/ExprValue.java
Show resolved
Hide resolved
...amazon/opendistroforelasticsearch/sql/query/planner/physical/node/scroll/PhysicalScroll.java
Outdated
Show resolved
Hide resolved
...forelasticsearch/sql/query/planner/physical/node/scroll/SearchAggregationResponseHelper.java
Show resolved
Hide resolved
dai-chen
approved these changes
Jan 21, 2020
chloe-zh
reviewed
Jan 22, 2020
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Does it work if the number of parameters in basic arithmetic expressions is indeterminate? eg. max(field_1) + max(field_2) + max(field_3) + ...
There was a problem hiding this comment.
Yes, it will be compile as add(max(field_1),add(max(field_2),max(field_3)).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Problem Statement
Support expression over aggregation function is an important feature has been request a lot by customer. The current SQL engine try to translate all the expression to painless script if possible which limit the implementation. This PR works on add the post processing logic into the current framework for aggregation query which is the first step to enable the expression over aggregation function support.
Change Notes
Integration Test changes
Todo
The next PR will address the following pieces
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.